fix: make sure the diff is always positive #93
Conversation
|
I have tried different approaches and this is the only one that has worked for me. As far as I can see the value is always correct, it just has a '-' in front of it. The fix is verified by checking that it works on my phone, which has been showing negative numbers until this fix. |
src/GeoLocationAge.tsx
Outdated
| }, [location]) | ||
|
|
||
| return <time dateTime={age.toISOString()}>{diff}</time> | ||
| return <time dateTime={age.toISOString()}>{diff.replace(/^-\s*/, '')}</time> |
There was a problem hiding this comment.
Hehe, nice.
I think Math.abs is a better solution.
And this does not look like a fix, because it would just convert negative distance to positive, which is not correct.
|
This seems to be cause by date-fns/date-fns#3238 |
|
|
I removed GeoLocationAge and used RelativeTime instead. intlFormatDistance was only used once in this repo. The change I see is that we loose the 'ago' behind the time. We are also missing the 'yesterday' text and getting '16h' for example. I can also see that the location time changes more in this version than in saga right now. Do we have any rules on when they should be updated? Attaching a photo of localhost in this branch VS world.thingy.rocks: |
Please remove it. |
What does "more" mean? |
It is removed! |
If you look at 'Sly 91X' in the screenshot I added the version in saga (to the right) says Wi-Fi was updated 1h ago, while in this branch is says 3s and it will count up. Same with 'single-cell': 1h VS 2m. I am passing in 'location.ts' to Relativetime so I believe it should only update when location is updated so I'm not sure why we have the differences. |
|
I believe this is just because the left has more recent updates to the geo location. |
|
I've changed the unit of the time to be distinguishable now from distance. 
|
closes #92