-
Notifications
You must be signed in to change notification settings - Fork 29
Update shared to 231 #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update shared to 231 #548
Conversation
After this, the project does not build correctly anymore. It is by intention that the issues are fixed one by one in the following commits.
Running `eslint --fix .` mostly added commas and changed whitespace.
Specifying the typeRoots was not necessary and with the new TypeScript version caused the error "Cannot find type definition file for 'sass'.".
Will be fixed later.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Upgrade to shared tooling (pc-nrfconnect-shared v231) triggering formatting (trailing commas) and lint adjustments across the codebase. Most changes are stylistic; a few functional-adjacent edits include a refactor of removeFile, enum commentary updates, hash function type annotations, and license header changes.
- Dependency bump: @nordicsemiconductor/pc-nrfconnect-shared to ^231.0.0
- Formatting: Prettier/eslint-driven trailing commas and minor syntactic normalization
- Minor logic/meta updates: revised removeFile implementation, added linter disables, modified license header
Reviewed Changes
Copilot reviewed 29 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/usbsdfuHelpers.ts | Stylistic comma additions |
| src/util/regions.ts | Added inline eslint disables and comment; spelling issue introduced |
| src/util/devices.ts | Trailing comma/style updates |
| src/util/tests/regions-test.ts | Style: added commas in expect/find calls |
| src/useOpenFileFromArgs.ts | Added trailing commas in logger calls |
| src/reducers/userInputReducer.ts | Added trailing comma in action signature |
| src/reducers/deviceDefinitionReducer.ts | Added trailing commas in reducer action signatures |
| src/index.tsx | Trailing comma after JSX argument |
| src/components/UserInputDialogView.tsx | Added dependency array comma & find callback comma |
| src/components/UsbSdfuUpdateDialog.tsx | Trailing commas in dispatched actions |
| src/components/RegionView.tsx | Added trailing comma in DOM lookup |
| src/components/ModemUpdateDialogView.tsx | Trailing commas in callbacks & program call |
| src/components/McuUpdateDialogView.tsx | Trailing commas, persistence call formatting |
| src/components/FileMemoryView.tsx | Comma additions & message punctuation |
| src/components/DeviceMemoryView.tsx | Comma/style updates |
| src/components/DeviceMemoryBoxView.tsx | Trailing comma in helper function args |
| src/components/DeviceInfoView.tsx | Added trailing comma in map callback |
| src/components/CoreView.tsx | Trailing commas after JSX children |
| src/components/ControlPanel.tsx | Trailing commas; simplified catch blocks |
| src/actions/userInputActions.ts | Trailing comma in thunk parameters |
| src/actions/usbsdfuTargetActions.ts | Trailing commas; modified hash function parameter types (issue) |
| src/actions/targetActions.ts | Trailing commas in dispatch branches |
| src/actions/modemTargetActions.ts | Trailing commas in performUpdate signature/call |
| src/actions/mcubootTargetActions.ts | Trailing commas in performUpdate signature/call |
| src/actions/jlinkTargetActions.ts | Extensive trailing commas & formatting |
| src/actions/fileActions.ts | Refactored removeFile logic & formatting |
| package.json | Dependency version bump |
| LICENSE | Replaced SPDX line with custom header block |
| Changelog.md | Bullet/indentation normalization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Also ran `npm update @types/node --save-dev` to fix some type issues.
f88a5bb to
cb5ad75
Compare
Because of updates to Prettier, typescript-eslint, and Prettier this contains a lot other changes but most of them are minor and purely stylistic.