Fix: Failing app release still created GH release #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nordic-publish script checks that the app is in a releasable state, e.g. if an official release is done that there is an appropriate entry in the changelog. But the GitHub release was created before that check. So, if the the check failed, a GitHub release was still created. So that had to be removed manually before trying another release. Because of this, the nordic-publish is now run before creating the GitHub release. Even better would be to run _all_ release checks before either creating the GitHub release or releasing to Artifactory but that would be more effort than this simpler fix.
datenreisender
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes a workflow ordering issue where GitHub releases were being created before validation checks, causing releases to persist even when the publish script failed its checks (e.g., missing changelog entries).
Key Changes:
- Reordered workflow steps to run
nordic-publish.jsvalidation before creating the GitHub release
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nordic-publish script checks that the app is in a releasable state, e.g. if an official release is done that there is an appropriate entry in the changelog.
But the GitHub release was created before that check.
So, if the the check failed, a GitHub release was still created. So that had to be removed manually before trying another release.
Because of this, the nordic-publish is now run before creating the GitHub release.
Even better would be to run all release checks before either creating the GitHub release or releasing to Artifactory but that would be more effort than this simpler fix.