Use 'endpoint' namedtuple type for address/port#5
Open
nealjack wants to merge 2 commits intoNordicSemiconductor:masterfrom
Open
Use 'endpoint' namedtuple type for address/port#5nealjack wants to merge 2 commits intoNordicSemiconductor:masterfrom
nealjack wants to merge 2 commits intoNordicSemiconductor:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects using piccata assume the endpoints returned to a received callback are using the
Endpointnamedtuple, but the exampletsocketreturns a regular tuple. This leads to errors when trying to swap out transports in projects that assume theEndpointnamedtuple, for example pc-nrfutil'screate_dfu_server.