Add fragmented encoding + redesign fragmented decoding #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
3 times, most recently
from
e6ca233 to
74bb51c
Compare
oyvindronningstad
requested review from
anhmolt,
hakonfam,
jonathannilsen,
karstenkoenig and
sigvartmh
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
3 times, most recently
from
9172de8 to
3fb70e4
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
2 times, most recently
from
4e0e367 to
32665df
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
2 times, most recently
from
e167b55 to
c05f01c
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
from
c05f01c to
be422b1
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
from
be422b1 to
3f23f1b
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
from
3f23f1b to
f873658
Compare
|
Is this code in a usable/testable state? |
Collaborator
Author
|
@omnisci3nce It's in a testable state, yes. |
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
3 times, most recently
from
9519c91 to
c43127c
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
from
c43127c to
cc465f0
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
3 times, most recently
from
3d15817 to
4aa9fd8
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
from
4aa9fd8 to
c4da4cc
Compare
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
3 times, most recently
from
5d45329 to
a8ae98c
Compare
Place fragments in the state struct so the user doesn't need to keep track of them. Signed-off-by: Øyvind Rønningstad <[email protected]>
to match the redesigned decoding API. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
fragmented-encoding
branch
from
a8ae98c to
4366d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244