zcbor.py: Add support for unordered maps in generated code #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
map-search-py
branch
2 times, most recently
from
10152df to
36e9986
Compare
oyvindronningstad
requested review from
anhmolt,
hakonfam,
jonathannilsen,
karstenkoenig and
sigvartmh
oyvindronningstad
force-pushed
the
map-search-py
branch
2 times, most recently
from
f32fa46 to
087ba75
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
from
087ba75 to
784c7c2
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
8 times, most recently
from
40b1e6b to
60ba45c
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
from
60ba45c to
1f2aa22
Compare
|
@oyvindronningstad Any traction here? Will we get this for NCS 2.8? |
darkofc
reviewed
Oct 22, 2024
oyvindronningstad
force-pushed
the
map-search-py
branch
2 times, most recently
from
2d99eec to
0fe723f
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
from
0fe723f to
9c305b4
Compare
darkofc
reviewed
Dec 5, 2024
zcbor/zcbor.py
Outdated
| {(linesep + " ").join(((str(relativify(f)) for f in include_dirs)))} | ||
| ) | ||
| """ | ||
| {f"\n{smart_search}\n" if add_smart_search else ''}""" |
There was a problem hiding this comment.
Nit: The use of backslashes in the formatted string doesn't work on version 3.10 python - forced me to update python to pickup this change.
oyvindronningstad
force-pushed
the
map-search-py
branch
3 times, most recently
from
26f2074 to
6ee1278
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
from
6ee1278 to
c68b43c
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
7 times, most recently
from
d229ca7 to
712a778
Compare
|
@oyvindronningstad @darkofc It would be really great if this PR could be merged so that we can start to use this feature |
oyvindronningstad
force-pushed
the
map-search-py
branch
from
712a778 to
4d0b6ea
Compare
Collaborator
Author
|
@jtguggedal I'm working on it. Sorry it's taken a long time, but each time I come back to it, I change it quite a bit, because it would be prone to bugs or user error. It contains surprisingly many tricky edge cases and tough decisions. Hoping to finish it soon. |
Good stuff, thanks for the update! |
oyvindronningstad
force-pushed
the
map-search-py
branch
4 times, most recently
from
b43d6c5 to
17e1aeb
Compare
oyvindronningstad
force-pushed
the
map-search-py
branch
from
17e1aeb to
cbe2e46
Compare
together with the zcbor state. Signed-off-by: Øyvind Rønningstad <[email protected]>
I.e. in unions and repetitions. In both cases, it's ok to fail decoding something because it's optional, and if the union element or repeated data being decoded includes multiple map elements, backups are needed in case flags have been set for some map elements, then fails later. In that case, the previous map elements' flags must be undone, and a backup is the way to keep the old state so it can be restored. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
map-search-py
branch
4 times, most recently
from
1d24eb4 to
dbee639
Compare
Add support for the --unordered-maps option to zcbor code which makes use of the zcbor_unordered_maps_*() API in generated code. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
map-search-py
branch
from
dbee639 to
aad09cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the --unordered-maps option to zcbor code
which makes use of the zcbor_unordered_maps_*() API in generated code.
Fixes #411