Refactor .eq, .default, .size, etc. to accept types, not just numbers #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
force-pushed
the
refactor-.eq
branch
from
9f6627f to
81bc5f6
Compare
oyvindronningstad
changed the title
Open
oyvindronningstad
force-pushed
the
refactor-.eq
branch
from
81bc5f6 to
c86c090
Compare
oyvindronningstad
requested review from
hakonfam,
jonathannilsen and
karstenkoenig
oyvindronningstad
force-pushed
the
refactor-.eq
branch
2 times, most recently
from
054e6d6 to
a7de934
Compare
|
Trying your branch on the issue, described in #516 it does improve the error message but ideally it would also support defaults for choices (no idea how much extra effort that would be, though). |
oyvindronningstad
force-pushed
the
refactor-.eq
branch
3 times, most recently
from
059a0fb to
8f8c8ed
Compare
oyvindronningstad
force-pushed
the
refactor-.eq
branch
from
8f8c8ed to
449be01
Compare
oyvindronningstad
force-pushed
the
refactor-.eq
branch
from
449be01 to
0befc24
Compare
Until now it has only been run as a subclass. Signed-off-by: Øyvind Rønningstad <[email protected]>
Signed-off-by: Øyvind Rønningstad <[email protected]>
Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
refactor-.eq
branch
from
0befc24 to
c242962
Compare
in argparse Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
refactor-.eq
branch
from
77fcad9 to
3b03fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472