zcbor_common: Add support for backing up elem_state #504
+383
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindronningstad
changed the title
oyvindronningstad
force-pushed
the
backup-elem_state
branch
from
eb6ecde to
7fc9629
Compare
oyvindronningstad
force-pushed
the
backup-elem_state
branch
5 times, most recently
from
40404d5 to
1f405ae
Compare
oyvindronningstad
force-pushed
the
backup-elem_state
branch
2 times, most recently
from
07ba35a to
5dec230
Compare
oyvindronningstad
force-pushed
the
backup-elem_state
branch
4 times, most recently
from
2b0a465 to
4786c7a
Compare
oyvindronningstad
force-pushed
the
backup-elem_state
branch
from
4786c7a to
f979a0e
Compare
oyvindronningstad
force-pushed
the
backup-elem_state
branch
3 times, most recently
from
f4d94ac to
3070b7e
Compare
oyvindronningstad
force-pushed
the
backup-elem_state
branch
2 times, most recently
from
b8a619e to
03c5ab2
Compare
oyvindronningstad
force-pushed
the
backup-elem_state
branch
from
03c5ab2 to
d89f612
Compare
Implement strict_load(). Signed-off-by: Øyvind Rønningstad <[email protected]>
Signed-off-by: Øyvind Rønningstad <[email protected]>
together with the zcbor state. Signed-off-by: Øyvind Rønningstad <[email protected]>
Signed-off-by: Øyvind Rønningstad <[email protected]>
I.e. in unions and repetitions. In both cases, it's ok to fail decoding something because it's optional, and if the union element or repeated data being decoded includes multiple map elements, backups are needed in case flags have been set for some map elements, then fails later. In that case, the previous map elements' flags must be undone, and a backup is the way to keep the old state so it can be restored. Signed-off-by: Øyvind Rønningstad <[email protected]>
oyvindronningstad
force-pushed
the
backup-elem_state
branch
from
d89f612 to
6399d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
together with the zcbor state.
src: Use elem_state backup in relevant functions
I.e. in unions and repetitions. In both cases, it's ok to fail decoding
something because it's optional, and if the union element or repeated data
being decoded includes multiple map elements, backups are needed in case
flags have been set for some map elements, then fails later. In that case,
the previous map elements' flags must be undone, and a backup is the way
to keep the old state so it can be restored.