MIDI-70: (VQ)VAE ECG #8
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelJanas
reviewed
Sep 29, 2023
pipeline/vae_ecg/main.py
Outdated
| ) -> dict[str, torch.Tensor]: | ||
| recon_batch, mu, logvar = model(data) | ||
|
|
||
| magic_factor = 0.1 |
Contributor
There was a problem hiding this comment.
would it be a good idea to move the magic_factor to config?
Member
Author
There was a problem hiding this comment.
For sure, I only need to remember what it is first 🥲
Contributor
There was a problem hiding this comment.
We had some trouble with exploding gradients in this model iirc, this might be the value to control it? Some implementations also used weights near the loss, it might be one of them?
Member
Author
There was a problem hiding this comment.
From what I recall it's about scaling the loss components, we had a discussion about it here: #7 I wanted to get rid of the sum reduction, to get operate on per-sample values. I think chat gpt advised me to add a scaling factor of reconstruction loss :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAE Reconstruction:
embedding_size=256embedding_size=16