Skip to content

MIDI-104: Datasets comparison #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SamuelJanas wants to merge 4 commits into
base: MIDI-86/autoencoder-research-blogpost
Choose a base branch
from
Open

MIDI-104: Datasets comparison #4

SamuelJanas wants to merge 4 commits into from

Conversation

@SamuelJanas
Copy link

@SamuelJanas SamuelJanas commented Oct 8, 2023 •
edited
Loading

  • submitted a draft
  • test fairness/multi-run
  • Find bottlenecks in Dataset
  • optimize
  • Write tips in the blogpost

@SamuelJanas
Copy link
Author

SamuelJanas commented Oct 8, 2023

It took longer than expected as I had to guarantee that the benchmarking was fair to the best of my knowledge.😅
I'll focus on finding the bottlenecks for now to find some ways to improve the datasets overall.

@roszcz
Copy link
Member

roszcz commented Oct 8, 2023

Thanks, look good!

In terms of presentation, I think we can hide the detailed code used to generate the results and focus here only on the performance metrics. Can you move the code to a separate repository?

For the performance itself, can you also investigate impact of moving data to GPU, and parameters like num_workers in the torch DataLoader?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamuelJanas @roszcz