Skip to content

flake: remove flake-parts and nix-systems from flake - #1591

Merged
snoweuph merged 2 commits into
NotAShelf:mainfrom
imnotpoz:main
Jul 5, 2026
Merged

flake: remove flake-parts and nix-systems from flake#1591
snoweuph merged 2 commits into
NotAShelf:mainfrom
imnotpoz:main

Conversation

@imnotpoz

Copy link
Copy Markdown
Contributor

this was at first meant to be on a personal fork to minimize the inputs of my system's flake but since @NotAShelf shared his plans to get rid of those 2 inputs anyway I decided to clean it up and open this PR

nix-systems was replaced with lib.platforms.all

flake-parts was replaced with eachSystem and eachSystemPkgs

things I deemed small enough to inline were brought from separate files in flake/ into the flake itself, the bigger things or ones that could get bigger in the future were left under flake/

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions

github-actions Bot commented May 14, 2026

Copy link
Copy Markdown

🚀 Live preview deployed from 93aaf85

View it here:

Debug Information

Triggered by: snoweuph

HEAD at: main

Reruns: 3467

github-actions Bot pushed a commit that referenced this pull request May 14, 2026
Comment thread flake/packages.nix
github-actions Bot pushed a commit that referenced this pull request May 14, 2026
github-actions Bot pushed a commit that referenced this pull request May 15, 2026
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
@snoweuph

Copy link
Copy Markdown
Collaborator

Just dropping this from matrix here:

image

can't really give you a review on this one, because this is the kind of thing, that 100% depends on what raf decides in the end xD.

@imnotpoz

Copy link
Copy Markdown
Contributor Author

Just dropping this from matrix here:
image

can't really give you a review on this one, because this is the kind of thing, that 100% depends on what raf decides in the end xD.

responding to raf: there's no new ../s introduced in this PR, the only ones added have already been there

the ones that are here could be fixed by just doing "${self}/dupa" instead of ../dupa (or worse), I don't see these as issues of removing flake-parts

@snoweuph

Copy link
Copy Markdown
Collaborator

im becoming a digital mailman xD

@imnotpoz

Copy link
Copy Markdown
Contributor Author

well then tell raf to get his lazy ass over here!!!!!

@snoweuph

Copy link
Copy Markdown
Collaborator

well then tell raf to get his lazy ass over here!!!!!

I dont think so, he got new Wires I heared and is in fucking pain....

How about you get your ass on matrix :3 #nvf:notashelf.dev

@imnotpoz

Copy link
Copy Markdown
Contributor Author

thanks to @BANanaD3V for this image where I found this new function from the second commit

image

github-actions Bot pushed a commit that referenced this pull request May 20, 2026
Comment thread flake.nix Outdated
@imnotpoz
imnotpoz force-pushed the main branch 2 times, most recently from 6bd3a28 to fb79be1 Compare May 21, 2026 15:40
github-actions Bot pushed a commit that referenced this pull request May 21, 2026
@snoweuph snoweuph added this to the 0.9 milestone Jun 5, 2026
github-actions Bot pushed a commit that referenced this pull request Jun 6, 2026
@snoweuph

Copy link
Copy Markdown
Collaborator

what is currently blocking this from moving forward if I may ask?

@imnotpoz

Copy link
Copy Markdown
Contributor Author

I'm rebasing this right now, stuck on testing because internet is slow!!!
image

@snoweuph

Copy link
Copy Markdown
Collaborator

I'm rebasing this right now, stuck on testing because internet is slow!!! image

:bwaa:

@snoweuph

Copy link
Copy Markdown
Collaborator

also you sitll got conflicts

@NotAShelf

Copy link
Copy Markdown
Owner

what is currently blocking this from moving forward if I may ask?

I haven't had the time to nitpick.

@imnotpoz

Copy link
Copy Markdown
Contributor Author

rebased, new vm tests still work

github-actions Bot pushed a commit that referenced this pull request Jun 25, 2026
@imnotpoz

Copy link
Copy Markdown
Contributor Author

rebased with formatting fixes

@snoweuph

Copy link
Copy Markdown
Collaborator

all checks succesfull :3

@snoweuph snoweuph left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snoweuph
snoweuph enabled auto-merge (rebase) July 5, 2026 20:01
@snoweuph
snoweuph disabled auto-merge July 5, 2026 20:02
@snoweuph

snoweuph commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

rebased and gonna merge

github-actions Bot pushed a commit that referenced this pull request Jul 5, 2026
@snoweuph
snoweuph merged commit 5bd50f1 into NotAShelf:main Jul 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants