Add an OOP-based way of adding features#100
Open
cornusandu wants to merge 8 commits into
Open
Conversation
34c3685 to
57ee357
Compare
125fb4c to
d8b37bb
Compare
Fixed erroring out if the document was already loaded / interactive and the feature class didn't have onDOMLoaded() or onPageLoaded()
* Passed path to constructor * Improved types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add a way of defining features via class decorators.
How to?
Make a class
For your feature, make a class that has:
init(page)/async init(page): initialise featureonDOMLoaded(): runs on 'DOMContentLoaded'onPageLoaded(): runs on 'load'Using the decorator
Use the decorator like this (importing it from
core/defineFeature/defFeat.ts:Load your feature
Add the following line to
core/defineFeature/featList.ts:Note
Please keep in mind that decorators will NOT be in the build output. They will get resolved to JavaScript code that Chrome supports entirely at build-time. Eslint was also configured to understand the syntax.