Favorite Friends#101
Draft
Azuronate wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Allows users to "favorite" a friend, meaning they'll be "pinned" (an earlier name of my PR) and will always appear first among their friends on Home, Friends, and Profile. This saves time by letting them see updates and activities from the people that they care about most, regardless of their status (offline, online, playing, or in development/studio).
Note
"Favorite Friends" ≠ Trusted Friends. "Favoriting" a friend is purely cosmetic and empowers users to organize and keep tabs on friends they care about most.
Main Changes
.friends-carousel-tile) dropdown (.friend-tile-dropdown) to allow that friend to be "favorited."chrome.local.storage.Milestones
.friends-carousel-tile>.friend-tile-dropdown).friends-carousel-list-containerto put "favorited" friends first..avatar-card-containerin Friends page..avatar-cardsto put "favorited" friends first (Friends page).More to come soon! Please suggest features, suggestions, fixes, or anything else in the PR comments or in my thread!