migrator: update Sonarr/Whisparr RelativePath tables during root-folder migration#220
Open
nicholaskurjo wants to merge 1 commit intoNotifiarr:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EpisodeFiles.RelativePathMetadataFiles.RelativePathSubtitleFiles.RelativePathPathcolumnsRelativePathrewrite logic to normalize path separators when migrating between Windows and Linux style rootsWhy
Issue #214 reports that root-folder migration alone leaves additional Sonarr tables with mismatched separator styles in
RelativePath, causing re-scan churn and related DB/log issues after cross-OS migration.Implementation
AppTables("Sonarr")andAppTables("Whisparr")inpkg/starrs/migrator.goto include the threeRelativePathtablesrewritePathForTable(...):Pathcolumns: prefix replace (existing behavior)RelativePathcolumns: separator normalization based on old/new root styleupdateFilesRootFolder(...)now routes updates through this helperTests
Added
pkg/starrs/migrator_test.gowith coverage for:Pathrewrite behaviorRelativePathrewrite Win -> LinuxRelativePathrewrite Linux -> WinRelativePathtablesRan:
go test ./pkg/starrsgo test ./...(with temporary localfrontend/distplaceholder for embed during test run)Closes #214