Skip to content

fix(skills): label local skills correctly in skills list#1014

Closed
0xNyk wants to merge 1 commit intoNousResearch:mainfrom
0xNyk:fix/861-skills-list-local-source
Closed

fix(skills): label local skills correctly in skills list#1014
0xNyk wants to merge 1 commit intoNousResearch:mainfrom
0xNyk:fix/861-skills-list-local-source

Conversation

@0xNyk
Copy link
Contributor

@0xNyk 0xNyk commented Mar 12, 2026

Summary: fix skills list source classification so non-hub skills are no longer all labeled builtin.

Now distinguishes:

hub: from hub lockfile
builtin: present in bundled manifest (tools.skills_sync._read_manifest)
local: remaining skills under user skills dir
Also adds source filter local in CLI parser/help.

Tests added:

builtin vs hub vs local classification
source_filter=local behavior
Validation:
python -m pytest -o addopts=\ tests/hermes_cli/test_skills_hub.py tests/hermes_cli/test_skills_subparser.py tests/test_cli_init.py -q

Closes #861

@teknium1
Copy link
Contributor

Closing this as redundant.

The behavior from this PR is already on current main:

  • hermes skills list --source local already exists in hermes_cli/main.py
  • hermes_cli/skills_hub.py already distinguishes hub, builtin, and local
  • tests/hermes_cli/test_skills_hub.py already covers the three-way classification and source filters

Relevant current-main commits/blame points I checked:

  • d94519c5 added the local source classification/filter behavior
  • bb7cdc6d4 added the corresponding test_skills_hub.py coverage

Because the code and tests are already present, trying to merge this branch now just conflicts with current main without adding new behavior. Thanks for the patch and for writing it up clearly.

@teknium1 teknium1 closed this Mar 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skills list mislabels local skills as builtin

2 participants