fix: DeepSeek V3 parser drops tool calls when model returns multiple (#989)#1015
Closed
Bartok9 wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: DeepSeek V3 parser drops tool calls when model returns multiple (#989)#1015Bartok9 wants to merge 1 commit intoNousResearch:mainfrom
Bartok9 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
…ousResearch#989) The regex in DeepSeekV3ToolCallParser.PATTERN used greedy `.*` with re.DOTALL. When the model returned multiple tool calls, findall() merged them into a single match — silently dropping all but the last. Root cause: `(?P<type>.*)` consumed across <｜tool▁sep｜> delimiters until the last occurrence. Fix: Changed `.*` to `.*?` (non-greedy) in all three capture groups. Added comprehensive tests for single, multiple (2+), and 3+ tool calls. Closes NousResearch#989
|
duplicate #992 |
Contributor
Author
|
Closing as duplicate of #992 - thanks for pointing that out @imadreamerboy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The regex in
DeepSeekV3ToolCallParser.PATTERNused greedy.*withre.DOTALL. When the model returned multiple tool calls,findall()merged them into a single match — silently dropping all but the last one.Repro: Any DeepSeek V3 response with 2+ tool calls → only the last tool call was parsed.
Root Cause
(?P<type>.*)consumed across<｜tool▁sep｜>delimiters until the last occurrence.Fix
Changed
.*to.*?(non-greedy) in all three capture groups.Before:
1 match foundfor 2 tool callsAfter:
2 matches foundfor 2 tool callsTests Added
Closes #989