fix(cli): use angle brackets for config set placeholders#1027
Closed
nil957 wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(cli): use angle brackets for config set placeholders#1027nil957 wants to merge 1 commit intoNousResearch:mainfrom
nil957 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The setup completion screen displayed 'hermes config set KEY VALUE' which looked like a valid command. Users who copy-pasted it ended up with 'KEY: VALUE' literally written to their config file. Changed to 'hermes config set <key> <value>' to clearly indicate these are placeholders, following common CLI documentation conventions. Fixes NousResearch#926
Contributor
|
Thanks for the fix. This is redundant on current main now: the placeholder-syntax change already landed via PR #1322, which also completed the remaining config help text updates and added regression coverage around the setup summary and config command output. There isn’t unique remaining behavior here to salvage, so I’m closing this duplicate with credit for the same UX direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The setup completion screen displays:
Because
KEYandVALUElook like valid literals, users who copy-paste this line end up withKEY: VALUEwritten to their~/.hermes/config.yaml.Solution
Changed to angle bracket convention:
This follows common CLI documentation patterns and clearly indicates these are placeholders.
Changes
hermes_cli/config.py: Updated 4 occurrenceshermes_cli/setup.py: Updated 1 occurrenceFixes #926