fix: handle None args in build_tool_preview#453
Merged
teknium1 merged 1 commit intoNousResearch:mainfrom Mar 10, 2026
Merged
Conversation
When an LLM returns null/empty tool call arguments, json.loads() produces None. build_tool_preview then crashes with "argument of type 'NoneType' is not iterable" on the `in` check. Return None early when args is falsy.
teknium1
added a commit
that referenced
this pull request
Mar 10, 2026
…tool_preview Complements PR #453 by 0xbyt4. Adds isinstance(dict) guard in run_agent.py to catch cases where json.loads returns non-dict (e.g. null, list, string) before they reach downstream code. Also adds 15 tests for build_tool_preview covering None args, empty dicts, known/unknown tools, fallback keys, truncation, and all special-cased tools (process, todo, memory, session_search).
Contributor
|
Merged! Thanks for the fix @0xbyt4 🎉 Added a complementary guard upstream in Also added 15 tests for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_tool_preview()crashes withTypeError: argument of type 'NoneType' is not iterablewhen a model returns null/empty tool call argumentsjson.loads("null")producesNone, which is passed tobuild_tool_previewwherefallback_key in argsfailsargsis falsy