fix: sanitize chat payloads and provider precedence#903
Closed
adavyas wants to merge 3 commits intoNousResearch:mainfrom
Closed
fix: sanitize chat payloads and provider precedence#903adavyas wants to merge 3 commits intoNousResearch:mainfrom
adavyas wants to merge 3 commits intoNousResearch:mainfrom
Conversation
3657c51 to
0311e5a
Compare
332d605 to
9cdd752
Compare
Contributor
|
Opened salvage PR #1253 onto current main, preserving your authored commits for the substantive fixes. I omitted the stale redundant top-level \ rename because current main already uses . Thanks for the fixes and tests here. |
Contributor
|
Correction: the omitted redundant rename was the top-level skills-config command surface; current main already uses the existing "hermes skills config" flow. Salvage PR is #1253. |
Contributor
|
Merged via PR #1253. Your substantive commits were cherry-picked onto current main with authorship preserved where applicable. Thanks for the fix and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #893
Summary
This PR prevents Codex-only replay metadata from leaking into chat-completions requests and fixes provider precedence regressions in the CLI. It also replaces a multiprocessing lock in a checkpoint test so sandboxed CI runners do not fail on SemLock permissions.
Changes
Validation
Notes
A full local suite run did not complete within the manual time caps used here, but the previously failing points were reproduced and fixed, and the focused touched-file test set passed.