fix: make config set examples use placeholder syntax#957
Closed
stablegenius49 wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: make config set examples use placeholder syntax#957stablegenius49 wants to merge 1 commit intoNousResearch:mainfrom
stablegenius49 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
Contributor
|
Merged via PR #1322. Your substantive commit was cherry-picked onto current main with authorship preserved, with a small follow-up for the remaining fallback help text. Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KEY VALUEexamples with<key> <value>placeholders in the setup summary and config CLI outputconfig setusage text so copy-paste examples no longer write a literalKEY: VALUEentry into configTesting
/opt/homebrew/bin/python3.11 -m pytest -o addopts='' tests/hermes_cli/test_config.py tests/hermes_cli/test_set_config_value.py tests/hermes_cli/test_placeholder_usage.py -qCloses #926