fix: add exc_info=True to image generation error logging#960
Merged
Conversation
Adds full stack traces to error logs in _upscale_image() and image_generate_tool() for better debugging. Matches the pattern used across the rest of the codebase. Cherry-picked from PR #868 by aydnOktay. Co-authored-by: aydnOktay <aydnOktay@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from PR #868 by @aydnOktay (207 commits behind, applied manually).
Adds
exc_info=Trueto twologger.error()calls intools/image_generation_tool.pyso error logs include full stack traces instead of just the message string. Matches the pattern established in commit 0fdeffe across the rest of the codebase.Closes #868
Co-authored-by: aydnOktay aydnOktay@users.noreply.github.com