fix(doctor): treat configured honcho as available#962
Closed
PeterFile wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix(doctor): treat configured honcho as available#962PeterFile wants to merge 1 commit intoNousResearch:mainfrom
PeterFile wants to merge 1 commit intoNousResearch:mainfrom
Conversation
1 task
teknium1
pushed a commit
that referenced
this pull request
Mar 13, 2026
Doctor-only override so honcho shows as available when configured, even outside a live agent session. Runtime tool gate unchanged. Cherry-picked from PR #962 by PeterFile, rebased onto current main (post-#736 merge) with conflict resolution. Fixes #961 Co-authored-by: PeterFile <PeterFile@users.noreply.github.com>
teknium1
added a commit
that referenced
this pull request
Mar 13, 2026
fix(doctor): treat configured honcho as available
Contributor
|
Merged via PR #1129. Your commit was cherry-picked with authorship preserved onto current main (post-#736 merge). Direct merge would have silently dropped the Honcho Memory diagnostic section from doctor.py due to branch staleness — cherry-pick kept both your fix and #736's additions intact. Thanks for the clean fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a false negative in
hermes doctorfor Honcho.Today, doctor reuses the runtime availability gate for the
honchotoolset. That gate only becomes true after a live agent session has already initialized Honcho state and injected a session manager + session key. That is correct for runtime tool execution, but wrong for doctor diagnostics.This change keeps runtime behavior unchanged and only adjusts doctor output:
HonchoClientConfig.from_global_config()enabled=Truewith an API key presenthonchoas available instead of reportingsystem dependency not metThis is the smallest correct fix because it changes the diagnostic interpretation without relaxing the actual runtime gate for
query_user_context.Related Issue
Fixes #961
Type of Change
Changes Made
hermes_cli/doctor.pyto add a doctor-specific Honcho config check based onHonchoClientConfig.from_global_config().hermes_cli/doctor.pyto apply a doctor-only availability override for thehonchotoolset aftercheck_tool_availability()returns.tests/hermes_cli/test_doctor.pyfor:How to Test
enabled: trueand a valid API key in~/.honcho/config.json.hermes doctoronmainand observe⚠ honcho (system dependency not met).hermes doctoragain.honchois no longer misreported as a missing system dependency.source .venv/bin/activatePYTHONPATH=. pytest -o addopts='' -q tests/hermes_cli/test_doctor.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
cli-config.yaml.exampledid not require updatesScreenshots / Logs
Targeted test result: