fix(patch): use regex to detect line-number prefix to prevent pipe char corruption#970
Open
alireza78a wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(patch): use regex to detect line-number prefix to prevent pipe char corruption#970alireza78a wants to merge 1 commit intoNousResearch:mainfrom
alireza78a wants to merge 1 commit intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
V4A patch apply uses
if '|' in lineto strip line-number prefixes fromfile content. Any line containing
|— Python bitwise ops, shell pipes,SQL, Markdown tables — is split on the first
|and the left side isdropped. The file is rewritten with those lines corrupted, no error reported.
How It Works
Replaced the
'|' in linecheck withre.match(r'^\s*\d+\|', line).This matches only the actual line-number prefix format (
123|content)and leaves all other
|characters untouched.Tests
154 patch-related tests pass.