fix(gateway): avoid /start crash when config is a GatewayConfig#975
Open
stablegenius49 wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(gateway): avoid /start crash when config is a GatewayConfig#975stablegenius49 wants to merge 1 commit intoNousResearch:mainfrom
stablegenius49 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the Telegram
/startcrash reported in #973 by making gateway quick-command handling work with theGatewayConfigobject used at runtime.The gateway runner was treating
self.configlike a plain dict (self.config.get(...)), but the installed gateway path passes aGatewayConfigdataclass. That raisedAttributeError: 'GatewayConfig' object has no attribute 'get'before the normal/startflow could continue.Related Issue
Fixes #973
Type of Change
Changes Made
quick_commandstogateway/config.pyso gateway config loading preserves the configured quick-command map.GatewayRunner._handle_message()to support both dict configs (existing tests) andGatewayConfigobjects (real runtime path).GatewayConfig-backed quick commands intests/test_quick_commands.py.How to Test
python3.11 -m venv .venv && source .venv/bin/activate && pip install -e '.[dev]').python -m pytest -o addopts='' tests/test_quick_commands.py./start; it should no longer raiseGatewayConfig has no attribute 'get'.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
python -m pytest -o addopts='' tests/test_quick_commands.py→12 passed