fix: DeepSeek V3 parser drops multi-tool calls (greedy regex)#992
Open
Himess wants to merge 1 commit intoNousResearch:mainfrom
Open
fix: DeepSeek V3 parser drops multi-tool calls (greedy regex)#992Himess wants to merge 1 commit intoNousResearch:mainfrom
Himess wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The greedy `.*` captures with `re.DOTALL` cause `findall()` to merge multiple tool calls into a single match — silently dropping all but the last tool call. Switching to `.*?` (non-greedy) fixes extraction when models return multiple tool calls in one response. Adds test coverage for the DeepSeek V3 parser including a multi-tool call regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #989
Greedy
.*in thePATTERNregex causesfindall()to merge multiple tool calls into one match — only the last tool call survives. Switching to non-greedy.*?fixes multi-tool-call extraction.Also adds test coverage for the DeepSeek V3 parser (previously had none).
Change: 1 line regex fix + 52 lines of tests.