[4/N] Fix CI paths for new skyrl code now that we have removed one level of nesting#1141
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| branches: [ main ] | ||
| paths: | ||
| - 'skyrl/**' | ||
| - '**' |
There was a problem hiding this comment.
🟡 Overly broad ** path filter causes expensive GPU CI to trigger on every change
In gpu_skyrl.yaml, the paths filter was changed from 'skyrl/**' to '**', which matches every file in the repository. This makes the path filter entirely ineffective — the workflow will now trigger on every push to main and every pull request, regardless of whether the change is relevant (e.g., documentation-only changes, skyrl-gym changes, skyrl-agent changes, etc.).
Impact: unnecessary GPU resource costs
This workflow submits an Anyscale GPU CI job (gpu_skyrl.yaml:49), which is a paid compute resource. Previously, the 'skyrl/**' filter ensured this expensive workflow only ran when skyrl package code changed. Now it runs on every single change, wasting GPU compute resources.
The '.github/workflows/gpu_skyrl.yaml' entry on line 8 is also now completely redundant since '**' already matches it.
The correct fix would be to enumerate the specific top-level paths that the skyrl package now uses, e.g., 'skyrl/**', 'tests/**', 'pyproject.toml', etc.
Prompt for agents
In .github/workflows/gpu_skyrl.yaml, replace the overly broad '**' path glob on lines 7 and 11 with specific paths that reflect the new repo structure after removing the skyrl/ nesting. For example, paths like 'skyrl/**', 'tests/**', 'pyproject.toml', 'ci/**' would be appropriate for the push (line 7) and pull_request (line 11) path filters. The same fix should be applied to .github/workflows/cpu_skyrl.yaml lines 7 and 11 which have the identical issue.
Was this helpful? React with 👍 or 👎 to provide feedback.
| branches: [ main ] | ||
| paths: | ||
| - 'skyrl/**' | ||
| - '**' |
There was a problem hiding this comment.
🟡 Overly broad ** path filter causes CPU CI to trigger on every change
In cpu_skyrl.yaml, the paths filter was changed from 'skyrl/**' to '**', which matches every file in the repository. This effectively removes all path-based filtering, causing the SkyRL-CPU workflow to run on every push and every PR, even for unrelated changes to skyrl-gym, skyrl-agent, docs, etc.
Impact: unnecessary CI runs on every PR
Every PR will now trigger this workflow even if it only touches documentation, skyrl-gym, or other unrelated packages. The .github/workflows/cpu_skyrl.yaml entry on line 8 is also completely redundant since '**' already matches it.
The correct fix would be to enumerate the specific paths relevant to the skyrl package at its new location, e.g., 'skyrl/**', 'tests/**', 'pyproject.toml', etc.
Prompt for agents
In .github/workflows/cpu_skyrl.yaml, replace the overly broad '**' path glob on lines 7 and 11 with specific paths that reflect the new repo structure. For example, paths like 'skyrl/**', 'tests/**', 'pyproject.toml' would be appropriate for the push (line 7) and pull_request (line 11) path filters, instead of the catch-all '**'.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Fixes
skyrltargeted CI.See #1138, #1139, #1140 for details on the code changes.