Stabilize Qwen3 MoE LoRA mixed-scale test#1640
Open
taivu1998 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new utility function, assert_allclose_mixed_scale, to the Qwen3 model tests for more precise numerical comparisons using a combination of base and scale-dependent absolute tolerances. Additionally, it updates test_qwen3_moe_layer_lora to use a seeded random generator for input data, ensuring test reproducibility. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Issue #1604 reports that tests/tx/models/test_qwen3.py::test_qwen3_moe_layer_lora compares tensors whose values span from small numbers to roughly 1e4. A fixed atol=1e-3 can make numerically equivalent JAX fused-LoRA and merged-weight paths fail on small-magnitude entries when the layer output has a much larger dynamic range.
Changes
Validation
Fixes #1604