Skip to content

Torch.jit.script #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Torch.jit.script #91

wants to merge 15 commits into from

Conversation

tcoroller
Copy link
Collaborator

No description provided.

@tcoroller tcoroller linked an issue Jan 2, 2025 that may be closed by this pull request
@tcoroller tcoroller marked this pull request as draft January 31, 2025 15:56
@tcoroller tcoroller self-assigned this Mar 14, 2025
@tcoroller tcoroller added the enhancement ✨ New feature or request label Mar 14, 2025
@tcoroller tcoroller added this to the 0.1.5 milestone Mar 14, 2025
@tcoroller
Copy link
Collaborator Author

@qiancao @melodiemonod please check the code, I have changed a lot of features to be compatible with torch.jit.script

@tcoroller tcoroller marked this pull request as ready for review March 14, 2025 17:40
@tcoroller tcoroller requested a review from kruscpe1 March 19, 2025 14:26
@tcoroller
Copy link
Collaborator Author

@qiancao @melodiemonod please let me know if you have any questions

)
return torch.ones_like(ct, dtype=ct.dtype)
weight = torch.ones(1, dtype=ct.dtype) / ct
weight = 1.0 / ct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two lines that assign values to weight independently, i think you want to keep the second one?

@melodiemonod
Copy link
Collaborator

Hi @tcoroller ,
Many thanks for having worked on all these tedious changes. It looks all fine to me. I ran successfully the notebooks and all the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TorchScript
3 participants