Skip to content

fix: regex for cran link#22

Merged
akselthomsen merged 19 commits intomainfrom
fix/lycheignore
May 20, 2025
Merged

fix: regex for cran link#22
akselthomsen merged 19 commits intomainfrom
fix/lycheignore

Conversation

@akselthomsen
Copy link
Copy Markdown
Member

@akselthomsen akselthomsen commented Apr 22, 2025

Fixes the following:

  1. The lychee linter correctly ignores the URLs that are dependent on system variables, which means they cannot be checked.
  2. The megalinter workflow now dynamically downloads the right configuration files to make it easier to check PRs such as this one:
    1. If running in this repo it will fetch all downloads from the branch causing the workflow to start
    2. For all other repos it uses the main branch

@akselthomsen akselthomsen linked an issue May 19, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

Code coverage

Name Coverage (%)
r.workflows 100
R/hello.R 100

@github-actions
Copy link
Copy Markdown

Github pages

Review the pkgdown webpage for the PR here

@akselthomsen akselthomsen self-assigned this May 20, 2025
@akselthomsen akselthomsen added the bug Something isn't working label May 20, 2025
Comment thread .github/workflows/megalinter.yaml
Copy link
Copy Markdown
Contributor

@rszymanski rszymanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🎉

@akselthomsen akselthomsen merged commit 5cf93dc into main May 20, 2025
14 checks passed
@akselthomsen akselthomsen deleted the fix/lycheignore branch May 20, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lychee linter lints .lycheeignore

2 participants