Aligned NN checks to use r-lib/actions/setup-r-dependencies@v2 #28
Merged
akselthomsen merged 3 commits intomainfrom Jun 6, 2025
Merged
Aligned NN checks to use r-lib/actions/setup-r-dependencies@v2 #28akselthomsen merged 3 commits intomainfrom
akselthomsen merged 3 commits intomainfrom
Conversation
…or standard R-CMD check
akselthomsen
reviewed
Jun 3, 2025
Member
akselthomsen
left a comment
akselthomsen
left a comment
There was a problem hiding this comment.
I am not sure this will still install the right versions of the packages.
Do we have a test of this?
Contributor
Author
|
If you now check the The |
akselthomsen
requested changes
Jun 5, 2025
Member
akselthomsen
left a comment
akselthomsen
left a comment
There was a problem hiding this comment.
Very neat solution!
such a nice improvement of the workflow.
I only have one more step (see comment) that we can delete as well.
Github pagesReview the pkgdown webpage for the PR here |
Code coverage
|
akselthomsen
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #27
This aligns the setup between the standard jobs and the NN jobs setting lock dates.