Add option to configure when R CMD check fails#29
Merged
rszymanski merged 1 commit intomainfrom Jun 6, 2025
Merged
Conversation
rszymanski
changed the title
rszymanski
force-pushed
the
feat/error-on-argument
branch
4 times, most recently
from
a36503d to
23df8c4
Compare
Useful if you want CI to fail on NOTEs
rszymanski
force-pushed
the
feat/error-on-argument
branch
from
23df8c4 to
3e09612
Compare
Github pagesReview the pkgdown webpage for the PR here |
Code coverage
|
akselthomsen
reviewed
Jun 6, 2025
akselthomsen
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the 'error-on' argument to both the check_current_version.yaml and check_nn_versions.yaml workflows
By default r-lib/actions/check-r-package@v2 sets it to 'warning' - which means that if the result contains NOTEs the workflow will still pass
By adding the argument you can opt-in for a more thorough check, it's still set to 'warning' by default to prevent breaking existing usage