Conversation
|
Looks nice, but please either add relevant support to |
|
please also add a test here: https://github.com/Nozbe/WatermelonDB/blob/master/src/__tests__/databaseTests.js#L860 that actually checks for correct behavior (not just expected query syntax). this is important for checking cross-adapter compatibility |
|
Thanks for your feedback |
I have chosen to throw an error, sorting on joined tables doesn't look to be supported currently on loki.js |
This comment was marked as off-topic.
This comment was marked as off-topic.
ace528b to
b90a8ca
Compare
feat: update ts definition for sortBy method fix: throw error when sort by is used on joined table with loki test: add integration test on sort on joined table
b90a8ca to
42dcad1
Compare
|
Is this still active? I am waiting for this. |
Currently if we make a query with joined tables, we cannot sort on columns of joined tables.
The goal of this PR is to be able to indicate on which table sort is applied