Open
Conversation
Avoiding ^ or ~ causes duplication of sub dependencies in consuming apps Libraries must be somewhat agnostic to the exact version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed duplicate babel/runtime version
The yarn.lock shows the duplication, even within WMDB repo itself. While the lockfile isn't used externally, the duplication looks identical to what a consuming app would experience.
The general advice is:
Avoid using exact versions when installing packages. Libraries must be especially agnostic about this, otherwise they force the consuming apps down hacky paths such as needing to define "resolutions" to avoid complex runtime issues (e.g. 2 versions of React modify the global scope and can cause random crashes, build errors, etc.)
Using fixed version instead of
^/~is very likely to cause duplicate installation of packages in consuming apps.