fix: Replace footer social media placeholder links - Fixes #84#94
Conversation
…uds#84 - Removed href='#' from social media links - Changed anchor tags to buttons with onClick handlers - Added toast notifications for 'Coming soon' feedback - All quick links already use proper routes with Link component - Improved accessibility with proper aria-labels
There was a problem hiding this comment.
Pull request overview
This PR updates the footer’s social media icons to avoid placeholder href="#" navigation by switching them to clickable controls that show “Coming soon” feedback via toast notifications, aligning behavior with the rest of the app’s routing and UX patterns.
Changes:
- Replaced social media
<a href="#">elements with<button>elements. - Added per-platform names and used them for accessible
aria-labels and toast messages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@akshay0611 review requested check it once!! |
|
Thanks for the update @Yashaswini-V21 . I re-verified PR #94 against issue #84. Most quick-link placeholder cleanup is done, but one required mapping is still pending:
Please update that link target and push the change, then I’ll do a quick re-review. |
|
The issue #84 was being assigned as a easy so I assigned easy to you. |
Removed href='#' from social media links
Changed anchor tags to buttons with onClick handlers
Added toast notifications for 'Coming soon' feedback
All quick links already use proper routes with Link component
Improved accessibility with proper aria-labels