Skip to content

Conversation

@Nsidorenco
Copy link
Owner

No description provided.

@Nsidorenco Nsidorenco force-pushed the fix/directory_filtering branch from b258393 to 86162b6 Compare October 8, 2025 21:07
@Nsidorenco Nsidorenco force-pushed the fix/directory_filtering branch from 86162b6 to 9d45c1d Compare October 12, 2025 17:34
@Nsidorenco Nsidorenco merged commit f252869 into feat/replace_fast_parse Oct 12, 2025
10 of 11 checks passed
@Nsidorenco Nsidorenco deleted the fix/directory_filtering branch October 12, 2025 17:41
Nsidorenco added a commit that referenced this pull request Oct 12, 2025
* feat: replace fast_parse

* fix: directory filtering (#43)
@liskin
Copy link
Contributor

liskin commented Oct 18, 2025

This broke test discovery for me — I'm only seeing about 180 tests instead of the 910+ that are there. Any tips how to diagnose this? I tried #47 but that broke test discovery completely, it gets stuck in "Parsing tests" forever.

Reverting 9d45c1d fixes the discovery for me. (One needs to git fetch origin 9d45c1d80f4b2db1b29d65b37897e3bb71cd8d81 first because that commit got squashed into some other one for some weird reason. I'd advise against using squash merges in the future to prevent these kinds of mistakes.)

liskin added a commit to liskin/dotfiles that referenced this pull request Oct 18, 2025
@Nsidorenco
Copy link
Owner Author

I inadvertently introduced a bug in the directory filtering. Sorry about that!
The problem is most likely we only look downwards for project files when filtering directories, so if the directory containing the tests are nested below the project file there is a chance it will be filtered out. (You can probably confirm this if you set neotest logging to trace and see directories it descents into)

I think #47 is on the right track so I'll focus on getting that to a point where we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants