Skip to content

Conversation

@Dynge
Copy link
Contributor

@Dynge Dynge commented Oct 17, 2025

The method to determine if the file is a test file did not take into account that it actually had tests for the file. It just checked that the file is from a project with a client.
There may be files that are not test files within the project.

@Dynge
Copy link
Contributor Author

Dynge commented Oct 18, 2025

Oh I just saw that #37 also adresses this.

In my test it did not slow down my test discovery significantly for a project with over 700 tests.

That project used the mtp client, so I guess the vstest client may be slower.

I'll check if the file is updated to become a test file later if it starts to contain tests.

@Dynge
Copy link
Contributor Author

Dynge commented Oct 18, 2025

Neotest does indeed rescan the file and adds it to the list. It is not immediate, I assumes theres some sort of worker periodically checking the files.

@Dynge Dynge force-pushed the mdl/push-pzyrmtktnkmp branch 3 times, most recently from d73a9f3 to 828b9fa Compare October 22, 2025 04:36
@Dynge
Copy link
Contributor Author

Dynge commented Nov 25, 2025

@Nsidorenco any thoughts on this PR? :)

The method to determine if the file is a test file did not take into
account that it actually had tests for the file. It just checked that
the file is from a project with a client.
There may be files that are not test files within the project.
@Dynge Dynge force-pushed the mdl/push-pzyrmtktnkmp branch from 828b9fa to e0e9912 Compare November 25, 2025 13:56
@Nsidorenco
Copy link
Owner

Thanks for the nudge @Dynge!

I'm a little worried that something like this would make the discovery process sluggish if a project contains many solutions but from testing out the branch it seems to work fine.

Let's merge this and potentially re-evaluate if issues arise

@Nsidorenco Nsidorenco merged commit a2d8ba7 into Nsidorenco:main Nov 25, 2025
6 checks passed
@Dynge Dynge deleted the mdl/push-pzyrmtktnkmp branch November 26, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants