fix: "Couldn't find positions in path" #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite often I get errors like this one:
ERROR | 2025-10-18T18:40:14Z+0100 | ...te/pack/bundle/start/neotest/lua/neotest/client/init.lua:309 | Couldn't find positions in path <redacted> ...tart/neotest-vstest/lua/neotest-vstest/vstest/client.lua:44: Expected value but found unexpected end of string at character 292
stack traceback:
[C]: in function 'decode'
...tart/neotest-vstest/lua/neotest-vstest/vstest/client.lua:44: in function 'discover_tests_in_project'
.../start/neotest-vstest/lua/neotest-vstest/vstest/init.lua:34: in function 'discover_tests'
...undle/start/neotest-vstest/lua/neotest-vstest/client.lua:39: in function 'discover_tests'
.../bundle/start/neotest-vstest/lua/neotest-vstest/init.lua:299: in function 'discover_positions'
...te/pack/bundle/start/neotest/lua/neotest/client/init.lua:300: in function <...te/pack/bundle/start/neotest/lua/neotest/client/init.lua:264>
[C]: in function 'xpcall'
...te/pack/bundle/start/neotest/lua/neotest/client/init.lua:264: in function '_update_positions'
...te/pack/bundle/start/neotest/lua/neotest/client/init.lua:317: in function <...te/pack/bundle/start/neotest/lua/neotest/client/init.lua:315>
I think that's because the test discovery doesn't flush the `outputFile`
before signalling back by writing "1" to the `waitFile`. Using `using`
to dispose of the `outputFile` `StreamWriter` seems to fix this — I
don't get those errors any more.
Contributor
|
Looks good to me. :) |
Owner
|
Makes a lot of sense - Thank you for investigating this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite often I get errors like this one:
I think that's because the test discovery doesn't flush the
outputFilebefore signalling back by writing "1" to thewaitFile. Usingusingto dispose of theoutputFileStreamWriterseems to fix this — I don't get those errors any more.