-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for .runsettings with vstest #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Super nice that you’re implementing this! |
|
I have been trying this with following config: Then in my .runsettigns: No file coverage is created though... Could you help me with this? |
|
@froats Hmm, I can try to debug. Is your custom settings selector finding the right file? If you run the tests with |
|
@froats I found an issue when a customs settings selector is used. Please try the latest revision from my fork. |
|
Hi, it is taking the file properly now, the coverage is still not being created though.. I will have to check why |
- Adding support for the (automatic) selection of a .runsettings file in a test project. - If more than one .runsettings file is present in a project directory, vim.ui.select is used to query the user for their choice. - Added a configuraiton option that allows the user to specify a function to find (or choose) a .runsettings file given a target project directory - Added an optional configuration option that allows the user to specify a timeout to use when communicating with the vstest client
|
This looks really good, thank you for contributing! Did you learn anything of why your coverage file was not generated @froats? |
|
I'll go ahead and merge this now. Thanks! |
Edit: This PR adds support for (automatically) selecting a .runsettings file that is located in the test project directory. If more than one .runsettings file is present, the user is given a choice via
vim.ui.select. The user can also specify a custom .runsettings selector function via the plugin configuration. I have also added a configuration option for the vstest client communication timeout.Notably missing from this PR are automated tests, and MTP/
.testconfig.jsonsupport. My current platform (linux/ubuntu) does not yet have an easy to obtain release of .NET10, but I will open a new PR to add MTP support once I can easily test it locally.WIP PR, looking for feedback.MTP has abandoned the.runsettingsformat in favour oftestconfig.json, so we will need to add client specific support for each.