Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

Refactor parser in preparation for block rules #94

Merged
merged 180 commits into from
Jan 2, 2021
Merged

Refactor parser in preparation for block rules #94

merged 180 commits into from
Jan 2, 2021

Conversation

emmiegit
Copy link
Member

@emmiegit emmiegit commented Dec 24, 2020 •
edited
Loading

Massive refactor of the parser to utilize the Parser pattern instead of (extracted, remaining), better maintaining pointer state and allowing easy try-lookahead without affecting current parser state. Going to merge as this is already big before the main block feature code.

Ammon Smith added 30 commits December 23, 2020 17:24
Create tag stub.
fa4b91a
Set maximum payload to 2MB.
9608c65
Start tag rule mapping.
95a51bb
Add documentation to Rule fields.
2a38034
Add arguments enums.
f0e4326
Rename tag -> block.
c519a84
Make ExtractedToken imports consistent.
4c99aae
Add body to BlockRule.
8dd5580
Add full_text to TryParseBlockFn.
bcfe7e1
Fix tests.
daa7611
Use alternate fn debug impl.
a9f5c6a
Add sub_names_mapping field instead.
b107d7f
Begin BlockParser structure.
6f0d46b
Add multiple spaces AST test.
d25b8d0
Add step() method.
7d79aad
Implement new BlockRule.
e2677b9
Start parse and add make_error().
e0e89f0
Remove argument and body modules, move value definitions.
54c9b93
Add newline.
54d0e8d
Run the block's parse function.
12b60e7
Add arguments and body methods.
3c67523
Working on block parse internals.
9d33d63
Add bounds to fix compilation.
e01d69f
Remove BlockRuleOld.
ace3845
Start block implementations.
913f459
Add test to ensure BLOCK_RULE_MAP is instantiated properly.
1f7734e
Add underscore to identifier rule.
f9f52c2
Implement get_identifier().
10a22d0
Get arguments in stubbed rules.
189afdf
Have block parse fn return Result.
7fc9474
Ammon Smith added 25 commits January 2, 2021 05:19
Add empty formatting tests.
9a4a429
Add empty strikethrough test.
c119071 
Kind of a special case, lol.
Add missing step to RULE_COLOR.
01a6e29 
Wasn't skipping over the initial '##'.
Fix comment rule.
fbec184
Fix end of input error.
6c00a1e
Remove nonexistent Token::LeftAnchor.
624b286 
The real token is Token::LeftBracketAnchor, not sure why the former was
accidentally added.
Add missing step in RULE_LINK_ANCHOR.
2f06541
Fix link single token check and step.
8ac1d1d
Add check_step() helper function.
37f2492
Step before link_triple separator check.
bf2fb7b
Add errors and tree as debugging context.
94e2920
Don't step in container.
d53e522 
Ends on the last token produced.
Modify collect_merge() parameters for early end.
3a435b7
Change how last token is returned / kept.
e93be83
Add missing check_step()s.
945e747
Change test error message.
2424219
Fix AST test expected errors.
b11a536
Fix raw pointer incrementation.
2ccb179 
These were originally slices of remaining, which is already +1.
Fix actual test failure output.
7086d0a 
lol
Add FullText::slice_inner().
940225b
Add slice_partial() method to FullText.
0274a51
Fix raw AST test errors.
2e8ffe7
Add horizontal rule (hr) rule.
9edb5fe
Add AST tests for horizontal rule (hr) rule.
947b758
Fix last AST test error.
ca43b1b
@emmiegit emmiegit changed the title Implement block parsing rule Refactor parser in preparation for block rules Jan 2, 2021
@emmiegit emmiegit marked this pull request as ready for review January 2, 2021 22:59
@emmiegit emmiegit merged commit fde12df into master Jan 2, 2021
@emmiegit emmiegit deleted the FTML-41 branch January 2, 2021 22:59
@emmiegit emmiegit mentioned this pull request Jan 2, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emmiegit