[Tech Spec] Supporting Bearer Auth #14174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR introduces a tech specification for supporting bearer token authentication for NuGet credential providers. The document outlines the functional and technical changes needed to update the NuGet CLI to support bearer auth, discusses drawbacks, and presents alternative schemes.
Reviewed Changes
| File | Description |
|---|---|
| accepted/2025/supporting-bearer-auth.md | New tech spec document detailing changes to enable bearer token auth |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
donnie-msft
reviewed
Mar 11, 2025
joelverhagen
previously approved these changes
Mar 11, 2025
zivkan
reviewed
Mar 12, 2025
Co-authored-by: Andy Zivkovic <[email protected]>
Co-authored-by: Andy Zivkovic <[email protected]>
Co-authored-by: Andy Zivkovic <[email protected]>
Co-authored-by: Andy Zivkovic <[email protected]>
Co-authored-by: Andy Zivkovic <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a technical specification detailing support for bearer token authentication in NuGet’s credential providers.
- Introduces a new spec document outlining the requirements and technical rationale.
- Describes the updated authentication behaviors and the limitations of the current .NET HttpClientHandler.
- Lists alternatives and future possibilities regarding credential handling.
Comments suppressed due to low confidence (1)
accepted/2025/supporting-bearer-auth.md:50
- The interface is referenced as 'ICredential', but the linked documentation refers to 'ICredentials'; please update for consistency.
Even though we are adding support for bearer tokens, the ICredential.GetCredential explicitly returns a NetworkCredential, which requires a username and password.
nkolev92
reviewed
Mar 13, 2025
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
embetten
reviewed
Mar 13, 2025
Co-authored-by: Andy Zivkovic <[email protected]>
Co-authored-by: Andy Zivkovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tech spec for #12877