Plugin discovery: make "nuget-plugin-*" plugin pattern matching cases sensitive #6255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Nigusu-Allehu
force-pushed
the
dev-nyenework-case-sensitivity-plugin-discovery
branch
from
e0b4ee8 to
00913b3
Compare
nkolev92
reviewed
Feb 7, 2025
nkolev92
previously approved these changes
Feb 7, 2025
This comment was marked as outdated.
This comment was marked as outdated.
zivkan
reviewed
Feb 9, 2025
Member
zivkan
left a comment
zivkan
left a comment
There was a problem hiding this comment.
Maybe I didn't take long enough to read the justification for why these tests don't run on .NET Framework, but it's really not clear to me.
Restore via msbuild.exe runs on .NET Framework, and should also be able to detect nuget-plugin-* plugins. The test seems just as relevant to me on .NET Framework as it does on the .NET (Core) runtime.
test/NuGet.Core.Tests/NuGet.Protocol.Tests/Plugins/PluginDiscovererTests.cs
Outdated
Show resolved
Hide resolved
test/NuGet.Core.Tests/NuGet.Protocol.Tests/Plugins/PluginDiscovererTests.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Status:No recent activity
|
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
dotnet-policy-service
bot
removed
the
Status:No recent activity
Nigusu-Allehu
changed the title
Nigusu-Allehu
force-pushed
the
dev-nyenework-case-sensitivity-plugin-discovery
branch
from
e08f176 to
66db33f
Compare
Nigusu-Allehu
changed the title
jeffkl
approved these changes
Feb 25, 2025
jebriede
approved these changes
Feb 25, 2025
Nigusu-Allehu
deleted the
dev-nyenework-case-sensitivity-plugin-discovery
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: #6138 (comment)
one of many fixes from NuGet/Home#13975
This PR makes sure plugin discovery is cases sensitive for "nuget-plugin-*" plugins. This is platform independent.
Description
PR Checklist