Conversation
| __np__.run_build_tool_exe("cmake", "cmake.exe", "-G", "Ninja", | ||
| "-DCMAKE_BUILD_TYPE=Release", "-DBUILD_CPU_DEMOS=OFF", | ||
| "-DBUILD_OPENGL3_DEMOS=OFF", "-DBUILD_UNIT_TESTS=OFF", | ||
| "-DINSTALL_LIBS=ON", | ||
| "-DCMAKE_INSTALL_PREFIX=" + install_dir, | ||
| src_dir) | ||
| __np__.run_build_tool_exe( | ||
| "cmake", | ||
| "cmake.exe", | ||
| "-G", | ||
| "Ninja", | ||
| "-DCMAKE_BUILD_TYPE=Release", | ||
| "-DBUILD_CPU_DEMOS=OFF", | ||
| "-DBUILD_OPENGL3_DEMOS=OFF", | ||
| "-DBUILD_UNIT_TESTS=OFF", | ||
| "-DINSTALL_LIBS=ON", | ||
| f'-DCMAKE_INSTALL_PREFIX={install_dir}', | ||
| src_dir, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function run refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| __np__.run_build_tool_exe("cmake", "cmake.exe", "-G", "Ninja", | ||
| "-DCMAKE_INSTALL_PREFIX=" + install_dir, | ||
| "-DCMAKE_BUILD_TYPE=Release", | ||
| "-DZLIB_ROOT=" + __np__.find_dep_root("zlib"), | ||
| "-DWITH_HarfBuzz=ON", "-DWITH_BZip2=OFF", | ||
| "-DWITH_PNG=OFF", | ||
| "-DHARFBUZZ_INCLUDE_DIRS=" + __np__.find_dep_include("harfbuzz"), | ||
| "-DPC_HARFBUZZ_INCLUDEDIR=" + __np__.find_dep_include("harfbuzz"), | ||
| "-DPC_HARFBUZZ_LIBDIR=" + __np__.find_dep_libs("harfbuzz"), | ||
| src_dir) | ||
| __np__.run_build_tool_exe( | ||
| "cmake", | ||
| "cmake.exe", | ||
| "-G", | ||
| "Ninja", | ||
| f'-DCMAKE_INSTALL_PREFIX={install_dir}', | ||
| "-DCMAKE_BUILD_TYPE=Release", | ||
| "-DZLIB_ROOT=" + __np__.find_dep_root("zlib"), | ||
| "-DWITH_HarfBuzz=ON", | ||
| "-DWITH_BZip2=OFF", | ||
| "-DWITH_PNG=OFF", | ||
| "-DHARFBUZZ_INCLUDE_DIRS=" + __np__.find_dep_include("harfbuzz"), | ||
| "-DPC_HARFBUZZ_INCLUDEDIR=" + __np__.find_dep_include("harfbuzz"), | ||
| "-DPC_HARFBUZZ_LIBDIR=" + __np__.find_dep_libs("harfbuzz"), | ||
| src_dir, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function run refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| __np__.run_build_tool_exe("cmake", "cmake.exe", "-G", "Ninja", | ||
| "-DCMAKE_BUILD_TYPE=Release", | ||
| "-DCMAKE_INSTALL_PREFIX=" + ft_install_dir, | ||
| "-DZLIB_ROOT=" + __np__.find_dep_root("zlib"), | ||
| "-DWITH_HarfBuzz=OFF", "-DWITH_BZip2=OFF", | ||
| "-DWITH_PNG=OFF", ft_src_dir) | ||
| __np__.run_build_tool_exe( | ||
| "cmake", | ||
| "cmake.exe", | ||
| "-G", | ||
| "Ninja", | ||
| "-DCMAKE_BUILD_TYPE=Release", | ||
| f'-DCMAKE_INSTALL_PREFIX={ft_install_dir}', | ||
| "-DZLIB_ROOT=" + __np__.find_dep_root("zlib"), | ||
| "-DWITH_HarfBuzz=OFF", | ||
| "-DWITH_BZip2=OFF", | ||
| "-DWITH_PNG=OFF", | ||
| ft_src_dir, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function run refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Sourcery Code Quality ReportMerging this PR leaves code quality unchanged.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
02dc30d to
f35ec90
Compare
5a577fb to
68183cd
Compare
|
Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!