Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minimum-versions issue #249

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix a minimum-versions issue #249

merged 2 commits into from
Oct 4, 2023

Conversation

g2p
Copy link
Contributor

@g2p g2p commented Oct 4, 2023

Tested with:

cargo +nightly update -Zminimal-versions; cargo check --all-features

See rust-lang/flate2-rs#221
(And #85 would be nice)

Tested with:

    cargo +nightly update -Zminimal-versions; cargo check --all-features

See rust-lang/flate2-rs#221
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a new job to CI which tests the minimal versions?

This is more exhaustive than the min-versions-shallow run that only
downgrades direct dependencies.

Closes Nullus157#85.
@g2p
Copy link
Contributor Author

g2p commented Oct 4, 2023

Can you add a new job to CI which tests the minimal versions?

Added!

@NobodyXu NobodyXu added this pull request to the merge queue Oct 4, 2023
@NobodyXu
Copy link
Collaborator

NobodyXu commented Oct 4, 2023

Thank you @g2p

Merged via the queue into Nullus157:main with commit 2fa53e2 Oct 4, 2023
16 checks passed
@robjtede
Copy link
Member

robjtede commented Oct 4, 2023

It's nice that the tools to catch this sort of stuff are getting easier to use!

Thanks @g2p!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants