Merge remote-tracking branch 'origin/main' into dkz/feature-grad-acoustic

Author: giordano

.github/workflows/Benchmarks.yml

@@ -22,7 +22,6 @@ env:
   # Don't make Reactant occupy all the GPU memory
   XLA_REACTANT_GPU_PREALLOCATE: 'false'
   JULIA_PKG_SERVER_REGISTRY_PREFERENCE: 'eager'
-  JULIA_PKG_SERVER: ''
 
 jobs:
   run-benchmarks:

.github/workflows/CI.yml

@@ -29,7 +29,6 @@ env:
   # Don't make Reactant occupy all the GPU memory
   XLA_REACTANT_GPU_PREALLOCATE: 'false'
   JULIA_PKG_SERVER_REGISTRY_PREFERENCE: 'eager'
-  JULIA_PKG_SERVER: ''
 
 jobs:
   test:
@@ -57,12 +56,12 @@ jobs:
           - version: "min"
             os: windows-latest
         include:
+          # `--check-bounds=auto` is necessary for testing Reactant workloads
+          # until https://github.com/EnzymeAD/Reactant.jl/issues/2347 is fixed.
           - version: "1.12.5"
             os: aws-linux-nvidia-gpu-l4
             arch: "default"
-            check-bounds: "yes"
-          # Necessary for testing Reactant workloads until
-          # https://github.com/EnzymeAD/Reactant.jl/issues/2347 is fixed.
+            check-bounds: "auto"
           - version: "1.11.9"
             os: aws-linux-nvidia-gpu-l4-4xl
             arch: "default"
@@ -85,7 +84,7 @@ jobs:
           # caches pkgimages and such, so we don't need to cache here most things.  Only
           # useful thing is the scratchspaces, in particular ParallelTestRunner's to make
           # scheduling of test jobs more efficients.
-          cache-artifacts: false
+          cache-artifacts: ${{ ! startsWith(matrix.os, 'aws-linux-nvidia-gpu-') }}
           cache-packages: ${{ ! startsWith(matrix.os, 'aws-linux-nvidia-gpu-') }}
           cache-registries: ${{ ! startsWith(matrix.os, 'aws-linux-nvidia-gpu-') }}
           cache-compiled: ${{ ! startsWith(matrix.os, 'aws-linux-nvidia-gpu-') }}

.github/workflows/Documentation.yml

@@ -26,7 +26,6 @@ env:
   # Don't make Reactant occupy all the GPU memory
   XLA_REACTANT_GPU_PREALLOCATE: 'false'
   JULIA_PKG_SERVER_REGISTRY_PREFERENCE: 'eager'
-  JULIA_PKG_SERVER: ''
 
 jobs:
   build-docs:
@@ -99,8 +98,6 @@ jobs:
         with:
           version: "1.12.5"
       - uses: julia-actions/cache@v3
-        with:
-          cache-registries: false
       - uses: actions/download-artifact@v8
         with:
           name: documentation-build

.github/workflows/Validation.yml

@@ -24,7 +24,6 @@ concurrency:
 
 env:
   JULIA_PKG_SERVER_REGISTRY_PREFERENCE: 'eager'
-  JULIA_PKG_SERVER: ''
 
 # needed to allow julia-actions/cache to delete old caches that it has created
 permissions:
@@ -49,8 +48,6 @@ jobs:
         with:
           version: ${{ matrix.version }}
       - uses: julia-actions/cache@v3
-        with:
-          cache-registries: false
       - name: Instantiate examples environment
         shell: julia --color=yes --project=examples {0}
         run: |

test/Project.toml

@@ -39,7 +39,7 @@ NCDatasets = "0.14"
 Oceananigans = "0.105.1, 0.106"
 ParallelTestRunner = "2.0.1"
 RRTMGP = "0.21"
-Reactant = "0.2.210"
+Reactant = "0.2.238"
 SpecialFunctions = "2"
 Statistics = "<0.0.1, 1"
 Test = "<0.0.1, 1"

test/quality_assurance.jl

@@ -9,15 +9,15 @@ using ClimaComms: ClimaComms
 using Dates: Dates
 using RRTMGP: RRTMGP
 using SpecialFunctions: SpecialFunctions
-if VERSION < v"1.12"
-    using Reactant: Reactant
+using Reactant: Reactant
 
+allow_unanalyzable = if VERSION < v"1.12"
     # For some reason `BreezeReactantExt` is non-analyzable,
     # but only in Julia v1.11-.
     BreezeReactantExt = isdefined(Base, :get_extension) ? Base.get_extension(Breeze, :BreezeReactantExt) : Breeze.BreezeReactantExt
-    allow_unanalyzable = (BreezeReactantExt,)
+    (BreezeReactantExt,)
 else
-    allow_unanalyzable = ()
+    ()
 end
 
 @testset "Aqua" begin

test/runtests.jl

@@ -8,11 +8,11 @@ testsuite = find_tests(@__DIR__)
 # Parse arguments
 args = parse_args(ARGS)
 
-const REACTANT_COMPAT = !((VERSION >= v"1.12") || (Base.JLOptions().check_bounds == 1))
+const REACTANT_COMPAT = VERSION < v"1.13-" && Base.JLOptions().check_bounds != 1
 
 if filter_tests!(testsuite, args)
     # Reactant compilation tests require --check-bounds=auto (Reactant/Enzyme
-    # limitation) and Julia < 1.12 until upstream support is improved.
+    # limitation).
     if !REACTANT_COMPAT
         delete!(testsuite, "reactant_centered_compilation")
         delete!(testsuite, "reactant_weno_compilation")