Skip to content

Rename gravity_constant to gravity #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Rename gravity_constant to gravity #174

merged 2 commits into from
Apr 17, 2025

Conversation

JoshuaLampert
Copy link
Member

@JoshuaLampert JoshuaLampert commented Apr 16, 2025

To stay consistent with the Trixi.jl ecosystem, cf. trixi-framework/Trixi.jl#2357 and to avoid any confusion.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (1ed4b8c) to head (2cb5747).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          20       20           
  Lines        1920     1920           
=======================================
  Hits         1883     1883           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 16, 2025

Benchmark Results

main 2cb5747... main/2cb574741aea57...
bbm_1d/bbm_1d_basic.jl 14.7 ± 0.65 μs 13.9 ± 0.36 μs 1.06
bbm_1d/bbm_1d_fourier.jl 0.527 ± 0.094 ms 0.527 ± 0.08 ms 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl 0.0805 ± 0.00042 ms 0.0806 ± 0.00046 ms 0.999
bbm_bbm_1d/bbm_bbm_1d_dg.jl 0.034 ± 0.00052 ms 0.0343 ± 0.00051 ms 0.992
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl 27.3 ± 0.43 μs 27.6 ± 0.46 μs 0.989
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl 0.0484 ± 0.00054 ms 0.0484 ± 0.00051 ms 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl 4.12 ± 0.014 μs 4.14 ± 0.013 μs 0.993
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl 0.197 ± 0.007 ms 0.203 ± 0.0086 ms 0.969
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl 0.145 ± 0.0036 ms 0.147 ± 0.0035 ms 0.985
time_to_load 1.97 ± 0.0015 s 2.02 ± 0.047 s 0.976

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Benchmark Plot

@JoshuaLampert JoshuaLampert marked this pull request as ready for review April 16, 2025 12:12
@JoshuaLampert JoshuaLampert requested a review from ranocha April 16, 2025 12:12
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit 5375770 into main Apr 17, 2025
18 checks passed
@JoshuaLampert JoshuaLampert deleted the rename-gravity branch April 17, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants