Skip to content

Comments

Adjust links according to transfer#176

Merged
JoshuaLampert merged 2 commits intomainfrom
transfer
Apr 26, 2025
Merged

Adjust links according to transfer#176
JoshuaLampert merged 2 commits intomainfrom
transfer

Conversation

@JoshuaLampert
Copy link
Member

I updated all links according to the transfer. I also bumped the version number so that I can release a new version after merging this PR (and after JuliaRegistries/General#129720 has been merged) to see if everything worked out.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@github-actions
Copy link
Contributor

Benchmark Results

main 522786d... main/522786dfbf52a2...
bbm_1d/bbm_1d_basic.jl 13.8 ± 0.31 μs 13.9 ± 0.39 μs 0.989
bbm_1d/bbm_1d_fourier.jl 0.529 ± 0.011 ms 0.531 ± 0.01 ms 0.995
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl 0.081 ± 0.00038 ms 0.0806 ± 0.00037 ms 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl 0.0342 ± 0.00052 ms 0.034 ± 0.00055 ms 1.01
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl 27.1 ± 0.47 μs 27.2 ± 0.53 μs 0.997
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl 0.0483 ± 0.0006 ms 0.0491 ± 0.00071 ms 0.985
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl 4.09 ± 0.013 μs 4.21 ± 0.016 μs 0.971
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl 0.202 ± 0.0086 ms 0.204 ± 0.0094 ms 0.992
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl 0.148 ± 0.005 ms 0.15 ± 0.005 ms 0.987
time_to_load 2.05 ± 0.021 s 2.08 ± 0.027 s 0.985

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Benchmark Plot

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@JoshuaLampert JoshuaLampert linked an issue Apr 25, 2025 that may be closed by this pull request
@JoshuaLampert JoshuaLampert merged commit 5ce3254 into main Apr 26, 2025
11 checks passed
@JoshuaLampert JoshuaLampert deleted the transfer branch April 26, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation Website is offline

3 participants