Skip to content

Comments

CompatHelper: bump compat for JET to 0.10 for package test, (keep existing compat)#194

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2025-05-09-00-36-11-697-03646008606
Closed

CompatHelper: bump compat for JET to 0.10 for package test, (keep existing compat)#194
github-actions[bot] wants to merge 1 commit intomainfrom
compathelper/new_version/2025-05-09-00-36-11-697-03646008606

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 9, 2025

This pull request changes the compat entry for the JET package from 0.9.9 to 0.9.9, 0.10 for package test.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@JoshuaLampert JoshuaLampert force-pushed the compathelper/new_version/2025-05-09-00-36-11-697-03646008606 branch from 35f4dfd to 26e4100 Compare May 9, 2025 00:36
@github-actions
Copy link
Contributor Author

github-actions bot commented May 9, 2025

Benchmark Results

main 26e4100... main/26e41002f38b29...
bbm_1d/bbm_1d_basic.jl 13.7 ± 0.28 μs 14.3 ± 0.48 μs 0.958
bbm_1d/bbm_1d_fourier.jl 0.223 ± 0.31 ms 0.526 ± 0.31 ms 0.424
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl 0.0809 ± 0.0004 ms 0.0806 ± 0.00044 ms 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl 0.0341 ± 0.00049 ms 0.0342 ± 0.00051 ms 0.996
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl 27.3 ± 0.48 μs 27.1 ± 0.43 μs 1.01
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl 0.0483 ± 0.00059 ms 0.048 ± 0.0016 ms 1.01
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl 4.11 ± 0.013 μs 4.13 ± 0.013 μs 0.997
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl 0.199 ± 0.0084 ms 0.195 ± 0.0086 ms 1.02
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl 0.147 ± 0.0054 ms 0.145 ± 0.0033 ms 1.01
time_to_load 2.02 ± 0.016 s 2.02 ± 0.012 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Benchmark Plot

@JoshuaLampert
Copy link
Member

Since JET.jl v0.9.19 it requires Julia v1.11 and since v0.10.0 it requires Julia v1.12, which means we cannot bump the compat of JET.jl to v0.10.

@JoshuaLampert JoshuaLampert mentioned this pull request Jun 7, 2025
6 tasks
@JoshuaLampert JoshuaLampert added the dependencies Pull requests that update a dependency file label Jun 22, 2025
@JoshuaLampert
Copy link
Member

Can be closed after having merged #216.

@ranocha ranocha deleted the compathelper/new_version/2025-05-09-00-36-11-697-03646008606 branch October 14, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant