Skip to content

Conversation

@JoshuaLampert
Copy link
Member

With the new julia-downgrade-compat v2, the action switched to use Resolver.jl to find minimal compatible versions. If everything works as intended, this makes it MUCH simpler to work with and debug the downgrade action because in case of incompatible lower bounds, you don't need to resolve the incompatibilities manually by finding out a set of working minimal bounds. This should now be done by Resolver.jl.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main 0d019bf... main / 0d019bf...
bbm_1d/bbm_1d_basic.jl - rhs!: 14.2 ± 0.36 μs 13.7 ± 0.27 μs 1.03 ± 0.033
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.526 ± 0.32 ms 0.219 ± 0.15 ms 2.4 ± 2.2
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.081 ± 0.00021 ms 0.0809 ± 0.00024 ms 1 ± 0.0039
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0342 ± 0.0011 ms 0.034 ± 0.00059 ms 1.01 ± 0.036
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.1 ± 0.44 μs 27.4 ± 2.6 μs 0.988 ± 0.094
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0505 ± 0.00075 ms 0.0487 ± 0.0028 ms 1.04 ± 0.062
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.4 ± 0.03 μs 4.22 ± 0.02 μs 1.04 ± 0.0087
kdv_1d/kdv_1d_basic.jl - rhs!: 1.45 ± 0.011 μs 1.41 ± 0.021 μs 1.03 ± 0.017
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.41 ± 0.011 μs 1.42 ± 0.021 μs 0.993 ± 0.017
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.199 ± 0.0093 ms 0.196 ± 0.0082 ms 1.01 ± 0.063
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.147 ± 0.0043 ms 0.144 ± 0.0037 ms 1.03 ± 0.04
time_to_load 1.95 ± 0.013 s 2.01 ± 0.016 s 0.972 ± 0.01
Memory benchmarks
main 0d019bf... main / 0d019bf...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@coveralls
Copy link
Collaborator

coveralls commented Jul 26, 2025

Pull Request Test Coverage Report for Build 19859222701

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.467%

Totals Coverage Status
Change from base Build 19858815486: 0.0%
Covered Lines: 2313
Relevant Lines: 2349

💛 - Coveralls

@JoshuaLampert
Copy link
Member Author

Hm, the Downgrade job seems to just use the same versions as the normal job (see https://github.com/NumericalMathematics/DispersiveShallowWater.jl/actions/runs/16541187956/job/46782631560?pr=227#step:8:57 and https://github.com/NumericalMathematics/DispersiveShallowWater.jl/actions/runs/16541187950/job/46782631572?pr=227#step:7:52) meaning it doesn't really test the compat bounds. Same also happens in SciML/SciMLBase.jl#1075. I think the new version is not quite ready yet.

@JoshuaLampert JoshuaLampert marked this pull request as draft July 26, 2025 19:00
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JoshuaLampert
Copy link
Member Author

I already prepared this PR to what would need to be done once StefanKarpinski/Resolver.jl#15 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants