Skip to content

Comments

Do not run benchmarks on non-code changes#245

Merged
JoshuaLampert merged 4 commits intomainfrom
ranocha-patch-1
Oct 23, 2025
Merged

Do not run benchmarks on non-code changes#245
JoshuaLampert merged 4 commits intomainfrom
ranocha-patch-1

Conversation

@ranocha
Copy link
Member

@ranocha ranocha commented Oct 23, 2025

Added paths to ignore for benchmark workflow.
@ranocha ranocha requested a review from JoshuaLampert October 23, 2025 03:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main 3a5c16f... main / 3a5c16f...
bbm_1d/bbm_1d_basic.jl - rhs!: 12.7 ± 1.2 μs 12.9 ± 0.6 μs 0.983 ± 0.1
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.248 ± 0.0076 ms 0.248 ± 0.0068 ms 0.998 ± 0.041
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0845 ± 0.012 ms 0.0852 ± 0.0037 ms 0.991 ± 0.15
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0323 ± 0.00054 ms 0.0324 ± 0.00095 ms 0.997 ± 0.034
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 25.5 ± 1.4 μs 25.5 ± 1.2 μs 0.998 ± 0.074
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0327 ± 0.0016 ms 0.0321 ± 0.0018 ms 1.02 ± 0.076
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 5.71 ± 0.2 μs 5.92 ± 0.38 μs 0.964 ± 0.07
kdv_1d/kdv_1d_basic.jl - rhs!: 2.22 ± 0.083 μs 1.74 ± 0.062 μs 1.27 ± 0.066
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.82 ± 0.026 μs 1.78 ± 0.088 μs 1.02 ± 0.053
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.215 ± 0.016 ms 0.209 ± 0.015 ms 1.03 ± 0.11
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.159 ± 0.011 ms 0.157 ± 0.011 ms 1.02 ± 0.098
time_to_load 1.89 ± 0.012 s 1.9 ± 0.017 s 0.999 ± 0.011
Memory benchmarks
main 3a5c16f... main / 3a5c16f...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ranocha and others added 3 commits October 23, 2025 08:37
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit 40e65b5 into main Oct 23, 2025
3 checks passed
@JoshuaLampert JoshuaLampert deleted the ranocha-patch-1 branch October 23, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants