Skip to content

Comments

Improve documentation of the analysis callback#266

Merged
JoshuaLampert merged 4 commits intomainfrom
ranocha-patch-2
Nov 25, 2025
Merged

Improve documentation of the analysis callback#266
JoshuaLampert merged 4 commits intomainfrom
ranocha-patch-2

Conversation

@ranocha
Copy link
Member

@ranocha ranocha commented Nov 24, 2025

@Alexander-Barth Does this address your comment in #264 sufficiently?

@ranocha ranocha added the documentation Improvements or additions to documentation label Nov 24, 2025
JoshuaLampert
JoshuaLampert previously approved these changes Nov 24, 2025
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@Alexander-Barth
Copy link

Alexander-Barth commented Nov 24, 2025

Can you quantify the "growth one would obtain from a standard spatial discretization that does not conserve these invariants" ? Just of the order of magnitude for this test case might be sufficient.

Or maybe it is easier to provide the initial total entropy? So that the reader can see that an increase of 0.005 corresponds to an increase of 10% or rather 0.0001% ...

@ranocha
Copy link
Member Author

ranocha commented Nov 24, 2025

Can you quantify the "growth one would obtain from a standard spatial discretization that does not conserve these invariants" ? Just of the order of magnitude for this test case might be sufficient.

Or maybe it is easier to provide the initial total entropy? So that the reader can see that an increase of 0.005 corresponds to an increase of 10% or rather 0.0001% ...

That's a good suggestion, thanks. I added this information on the relative change (which is of the order $10^{-6}$ in this case).

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks again!

@JoshuaLampert
Copy link
Member

Is this resolved from your perspective after merging this PR, @Alexander-Barth? You can see the preview of the documentation here: https://numericalmathematics.github.io/DispersiveShallowWater.jl/previews/PR266/callbacks/#Analysis-Callback.

@Alexander-Barth
Copy link

Yes, perfect! This is exactly the type of information behind my question.

@JoshuaLampert JoshuaLampert merged commit e3e9f19 into main Nov 25, 2025
4 checks passed
@JoshuaLampert JoshuaLampert deleted the ranocha-patch-2 branch November 25, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants